Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transaction settings screen UI #383

Merged

Conversation

Imamah-Zafar
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

(Optional) Resolved: #376

What is the new behavior?

The transaction setting screens have been updated according to the new UI

Screenshot / Video

Modifying Btc fee

BTC-EDIT-FEE.mov

Modifying Nft fee

nft-edit-fees.mov

Modifying Nonce

nonce.mov

@Imamah-Zafar
Copy link
Contributor Author

the latest commit has the fix for issue 384

ordinal-send.mov

@DuskaT021 DuskaT021 linked an issue May 3, 2023 that may be closed by this pull request
…-extension into imamahzafar/feat/update-transaction-settings-screen
@DuskaT021
Copy link
Contributor

Just a question, [this is on prod as well]

Scenario: when the fee amount is changed from default to fast for example, is it expected, when I reopen the advanced settings for the regular button to be active? Should't the lastly used button, be active - in my case it was fast button?

Screen.Recording.2023-05-04.at.23.52.36.mov

@DuskaT021
Copy link
Contributor

when clearing the fee amount input (btc transactions and ordinal transactions) and hitting apply the NaN value is displayed. We should handle it similarly like we do for stx transactions, which is if the input is cleared it should fallback to default or to display an error message.

Screen.Recording.2023-05-05.at.00.09.44.mov

@Imamah-Zafar
Copy link
Contributor Author

when clearing the fee amount input (btc transactions and ordinal transactions) and hitting apply the NaN value is displayed. We should handle it similarly like we do for stx transactions, which is if the input is cleared it should fallback to default or to display an error message.

Screen.Recording.2023-05-05.at.00.09.44.mov

#358
an issue is opened for this. we can prioritise this in the next sprint . but a separate PR can be made for this

@Imamah-Zafar
Copy link
Contributor Author

Just a question, [this is on prod as well]

Scenario: when the fee amount is changed from default to fast for example, is it expected, when I reopen the advanced settings for the regular button to be active? Should't the lastly used button, be active - in my case it was fast button?

Screen.Recording.2023-05-04.at.23.52.36.mov

you're right. the experience can be made better by storing the state. we can create an issue for this and deal it along with issue #358

@DuskaT021
Copy link
Contributor

This can be merged.
The last two comments will be addressed in issue #358
I'll link to them

@m-aboelenein m-aboelenein merged commit 06ec364 into develop May 8, 2023
1 check passed
@m-aboelenein m-aboelenein deleted the imamahzafar/feat/update-transaction-settings-screen branch May 8, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fee amount is not updated in the send Ordinal screen Ui-enhancement/ Update Transaction Settings Screen
3 participants